[Lldb-commits] [lldb] r261593 - Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in source/Commands/CommandObjectCommands.cpp; other minor fixes.

Eugene Zelenko via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 22 16:17:33 PST 2016

On Mon, Feb 22, 2016 at 4:14 PM, Adrian McCarthy <amccarth at google.com> wrote:
> It looks like this patch reorders the #includes in a way that seems contrary
> to general practice.  In particular, if foo.cpp has a header foo.h, then it
> should include foo.h before any other files.  This helps ensure that foo.h
> can stand alone and won't require clients to have to figure out what else
> must be included.
> http://llvm.org/docs/CodingStandards.html#include-style
> I know LLDB doesn't always follow LLVM guidelines, but this seems pretty
> common and intentional.

I try to follow headers section comments.


More information about the lldb-commits mailing list