[Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

So your LineTable::Entry objects that you create are still invalid since you didn't implement the support files.

All comments became unaligned but you did comment that:

> In CompileUnit.h, it says this:




  // A representation of a compilation unit, or compiled source file.
  // The UserID of the compile unit is specified by the SymbolFile
  // plug-in and can have any value as long as the value is unique
  // within the Module that owns this compile units.



> Are you sure it's an index into the support files? It sounds like maybe the DWARF plugin treats it as such, but it's not assumed to be such by any generic code.


I wasn't talking about the CompileUnit's UserID, I was talking about file indexes that are in the line tables that you create. The CompileUnit's UserID is what ever you want it to be and this is correct and will work for any debug info. The line tables use file indexes for files in the LineTable::Entry structures and they rely on the file index being a valid index into the CompilerUnit::GetSupportFiles() FileSpecList.


================
Comment at: source/Host/windows/HostInfoWindows.cpp:37
@@ +36,3 @@
+    HostInfoBase::Terminate();
+    CoUninitialize();
+}
----------------
Should be:

```
::CoUninitialize();
```


http://reviews.llvm.org/D17363