[Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 19 13:58:53 PST 2016

zturner added inline comments.

Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:150
@@ +149,3 @@
+    return TranslateLanguage(details->getLanguage());
Ahh i see the problem.  The problem is not the value Im' specifying for the id of the compile unit, but the value I'm specifying in the argument to the constructor of LineEntry, which is clearly documented as an index.

Using the `CompileUnit::GetSupportFileByID` seems difficult based on a cursory glance over how it's used, so for now I will just do some extra work to add support files and map ids to indices.

Later we can think about whether it's worth it to do that refactor to get rid of the assumption that they're indices.


More information about the lldb-commits mailing list