[Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

[Jim Ingham via lldb-commits]

My bad, that sees to be what it does.

Jim

> On Feb 10, 2016, at 4:59 PM, Zachary Turner <zturner at google.com> wrote:
> 
> zturner added a comment.
> 
> In http://reviews.llvm.org/D17107#349421, @jingham wrote:
> 
>> Unless something has changed since last I looked, the llvm path utilities are host specific.  I didn't inspect the code where this is being used, but it is in Host/common, so unless there's an ifdef WINDOWS around it, I don't think you should use the llvm path utilities.
>> 
>> Jim
> 
> 
> Unless I'm misunderstanding, code in `Host/Common` need only satisfy the property that it will work on every host with a single syntax.  That's what the llvm path libraries do as well.  so `llvm::sys::path::append('foo', 'bar')` will produce `foo\bar` on Windows, and `foo/bar` on Linux, OSX, etc.
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D17107
> 
> 
>