[Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 10 16:59:35 PST 2016

zturner added a comment.

In http://reviews.llvm.org/D17107#349421, @jingham wrote:

> Unless something has changed since last I looked, the llvm path utilities are host specific.  I didn't inspect the code where this is being used, but it is in Host/common, so unless there's an ifdef WINDOWS around it, I don't think you should use the llvm path utilities.
> Jim

Unless I'm misunderstanding, code in `Host/Common` need only satisfy the property that it will work on every host with a single syntax.  That's what the llvm path libraries do as well.  so `llvm::sys::path::append('foo', 'bar')` will produce `foo\bar` on Windows, and `foo/bar` on Linux, OSX, etc.



More information about the lldb-commits mailing list