[Lldb-commits] [PATCH] D16334: Fix TestSignedTypes.py by removing a bogus step-over

[Zachary Turner via lldb-commits]

Perhaps a middle ground to these two sides could be something along the
lines of "If you're going to make sweeping changes to remove a particular
feature from a set of tests, make sure there's a reasonable amount of
isolated coverage of the thing you're removing".

Honestly though, our culture of testing really needs to imrpove at the
larger scale going forward.  We need more tests, and we need to start
blocking or reverting CLs that don't have some amount test coverage.  A
common one that I see is "well this is just putting some infrastructure in
place that isn't being used anywhere yet".  But even that is still
testable.  That's exactly what unit tests, mock implementations, and
dependency injection are for.

On Wed, Jan 20, 2016 at 11:57 AM Zachary Turner <zturner at google.com> wrote:

> On Wed, Jan 20, 2016 at 11:48 AM Zachary Turner <zturner at google.com>
> wrote:
>
>>
>> If the problem is that people don't have the time because they've got too
>> much other stuff on their plate, that's not a good excuse and I don't think
>> we should intentionally encourage writing poor tests just because someone's
>> manager doesn't give them enough time to do things the right way.
>>
>
> Replace "someone's manager" with "the power's that be".  I didn't mean to
> sound like I was directing this at anyone in particular.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160120/bd686cfb/attachment.html>