[Lldb-commits] [PATCH] D16334: Fix TestSignedTypes.py by removing a bogus step-over

[Adrian McCarthy via lldb-commits]

amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.

Apparently something changed with `thread step-over`, causing execution to move outside the stack frame, and thus the local variables were no longer visible.

Since the step-over is unrelated to the purpose of the test and since the comment for that line was just plain wrong (the breakpoint set is already beyond the last assignment, so this seems legit), I deleted that step.

Tested on Windows with both Python 2.7 and 3.5.

http://reviews.llvm.org/D16334

Files:
  packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py

Index: packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
===================================================================
--- packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
+++ packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
@@ -48,9 +48,6 @@
         self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
-        # Execute the assignment statement.
-        self.runCmd("thread step-over")
-
         # Test that signed types display correctly.
         self.expect("frame variable --show-types --no-args", VARIABLES_DISPLAYED_CORRECTLY,
             patterns = ["\((short int|short)\) the_signed_short = 99",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16334.45314.patch
Type: text/x-patch
Size: 742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160120/bd3199e7/attachment.bin>