[Lldb-commits] [lldb] r258212 - Placate MVSC after my last commit.

Davide Italiano via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 19 14:47:51 PST 2016


Author: davide
Date: Tue Jan 19 16:47:51 2016
New Revision: 258212

URL: http://llvm.org/viewvc/llvm-project?rev=258212&view=rev
Log:
Placate MVSC after my last commit.

Zachary introduced the 'default' case explicitly to placate a warning in
the Microsoft compiler but that broke clang with -Werror. 
The new code should keep both compilers happy.

Modified:
    lldb/trunk/source/Expression/ExpressionSourceCode.cpp
    lldb/trunk/source/Target/Process.cpp

Modified: lldb/trunk/source/Expression/ExpressionSourceCode.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ExpressionSourceCode.cpp?rev=258212&r1=258211&r2=258212&view=diff
==============================================================================
--- lldb/trunk/source/Expression/ExpressionSourceCode.cpp (original)
+++ lldb/trunk/source/Expression/ExpressionSourceCode.cpp Tue Jan 19 16:47:51 2016
@@ -106,8 +106,6 @@ public:
         {
             case CURRENT_FILE_NOT_YET_PUSHED:
                 return true;
-            case CURRENT_FILE_POPPED:
-                return false;
             case CURRENT_FILE_PUSHED:
                 // If we are in file included in the current file,
                 // the entry should be added.
@@ -118,6 +116,8 @@ public:
                     return false;
                 else
                     return true;
+            default:
+                return false;
         }
     }
 

Modified: lldb/trunk/source/Target/Process.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=258212&r1=258211&r2=258212&view=diff
==============================================================================
--- lldb/trunk/source/Target/Process.cpp (original)
+++ lldb/trunk/source/Target/Process.cpp Tue Jan 19 16:47:51 2016
@@ -1489,12 +1489,6 @@ Process::IsAlive ()
 {
     switch (m_private_state.GetValue())
     {
-        case eStateInvalid:
-        case eStateUnloaded:
-        case eStateDetached:
-        case eStateExited:
-            return false;
-
         case eStateConnected:
         case eStateAttaching:
         case eStateLaunching:
@@ -1504,6 +1498,8 @@ Process::IsAlive ()
         case eStateCrashed:
         case eStateSuspended:
             return true;
+        default:
+            return false;
     }
 }
 




More information about the lldb-commits mailing list