[Lldb-commits] [lldb] r258199 - [Process] Remove dead code. All the switch cases are already covered.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 19 14:05:22 PST 2016


This is needed in order to prevent MSVC from warning about this case.  I
explicitly added these last week.  Can I ask that you revert this change?

On Tue, Jan 19, 2016 at 2:03 PM Davide Italiano via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> Author: davide
> Date: Tue Jan 19 15:59:12 2016
> New Revision: 258199
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258199&view=rev
> Log:
> [Process] Remove dead code. All the switch cases are already covered.
>
> Modified:
>     lldb/trunk/source/Expression/ExpressionSourceCode.cpp
>     lldb/trunk/source/Target/Process.cpp
>
> Modified: lldb/trunk/source/Expression/ExpressionSourceCode.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ExpressionSourceCode.cpp?rev=258199&r1=258198&r2=258199&view=diff
>
> ==============================================================================
> --- lldb/trunk/source/Expression/ExpressionSourceCode.cpp (original)
> +++ lldb/trunk/source/Expression/ExpressionSourceCode.cpp Tue Jan 19
> 15:59:12 2016
> @@ -118,8 +118,6 @@ public:
>                      return false;
>                  else
>                      return true;
> -            default:
> -                return false;
>          }
>      }
>
>
> Modified: lldb/trunk/source/Target/Process.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=258199&r1=258198&r2=258199&view=diff
>
> ==============================================================================
> --- lldb/trunk/source/Target/Process.cpp (original)
> +++ lldb/trunk/source/Target/Process.cpp Tue Jan 19 15:59:12 2016
> @@ -1504,8 +1504,6 @@ Process::IsAlive ()
>          case eStateCrashed:
>          case eStateSuspended:
>              return true;
> -        default:
> -            return false;
>      }
>  }
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160119/10278f0f/attachment.html>


More information about the lldb-commits mailing list