<div dir="ltr">This is needed in order to prevent MSVC from warning about this case. I explicitly added these last week. Can I ask that you revert this change?</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 19, 2016 at 2:03 PM Davide Italiano via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Tue Jan 19 15:59:12 2016<br>
New Revision: 258199<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=258199&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=258199&view=rev</a><br>
Log:<br>
[Process] Remove dead code. All the switch cases are already covered.<br>
<br>
Modified:<br>
lldb/trunk/source/Expression/ExpressionSourceCode.cpp<br>
lldb/trunk/source/Target/Process.cpp<br>
<br>
Modified: lldb/trunk/source/Expression/ExpressionSourceCode.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ExpressionSourceCode.cpp?rev=258199&r1=258198&r2=258199&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ExpressionSourceCode.cpp?rev=258199&r1=258198&r2=258199&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/source/Expression/ExpressionSourceCode.cpp (original)<br>
+++ lldb/trunk/source/Expression/ExpressionSourceCode.cpp Tue Jan 19 15:59:12 2016<br>
@@ -118,8 +118,6 @@ public:<br>
return false;<br>
else<br>
return true;<br>
- default:<br>
- return false;<br>
}<br>
}<br>
<br>
<br>
Modified: lldb/trunk/source/Target/Process.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=258199&r1=258198&r2=258199&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=258199&r1=258198&r2=258199&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/source/Target/Process.cpp (original)<br>
+++ lldb/trunk/source/Target/Process.cpp Tue Jan 19 15:59:12 2016<br>
@@ -1504,8 +1504,6 @@ Process::IsAlive ()<br>
case eStateCrashed:<br>
case eStateSuspended:<br>
return true;<br>
- default:<br>
- return false;<br>
}<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>