[Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

Sean Callanan via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 12 10:47:57 PST 2016

spyffe added a comment.

I'm a little concerned that LanguageRuntime::GetOverrideExprOptions() appears to generate a new set of options from whole cloth rather than using the existing set as a starting point.

Specifically, since your use case is wanting to override the calling convention, I think it's heavy handed to override all the options.  I could conceive of new expression parser features changing some other flags in the future, and it'd be unfortunate if we had to duplicate those features in the ActionScript code just because the options are being overridden.

Could we model this as OverrideExprOptions(clang::TargetOptions &) instead and modify the options in place?  That way customizations could stack.


More information about the lldb-commits mailing list