[Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

Luke Drummond via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 12 03:07:51 PST 2016

ldrumm requested a review of this revision.
ldrumm added a comment.


Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:85-97
@@ -83,1 +84,15 @@
+namespace {
+    void debugStringVector(Log *log, const std::vector<std::string>& vec, const char *name)
+    {
+        if(!log)
+            return;
+        log->Debug("Begin %s:", name);
+        for (const auto& s : vec)
+            log->Debug("%s", s.c_str());
+        log->Debug("End %s.", name);
+    }
clayborg wrote:
> We have an internal class named StringList that is a vector of strings. It would be nice to use that class instead of a direct std::vector and place this call inside the StringList class as a new method.
Thanks for the suggestion. I've added that as a separate commit, as it touches an entirely different codepath: http://reviews.llvm.org/D15773


More information about the lldb-commits mailing list