[Lldb-commits] [PATCH] D15593: Enhance "target modules dump line <file>" and use it to fix MI's -symbol-list-lines.

[Dawn Perchik via lldb-commits]

dawn marked 4 inline comments as done.
dawn added a comment.

Replies to Ilia's comments...


================
Comment at: source/Commands/CommandObjectTarget.cpp:1543
@@ +1542,3 @@
+                    continue;
+                CompileUnit *cu = cu_sp.get();
+                const FileSpecList &cu_file_list = cu->GetSupportFiles();
----------------
ki.stfu wrote:
> That's no problem. Just replace s/cu/cu_sp/ on lines #1544, #1565, #1580, #1594, and then use cu_sp.get() on line #1586.
this no longer applies to the most recent patch.

================
Comment at: source/Commands/CommandObjectTarget.cpp:2689
@@ +2688,3 @@
+                    break;
+            }
+
----------------
ki.stfu wrote:
> nit: you forgot the dot
did I forget a dot?

================
Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:226
@@ -225,3 @@
-            // Skip entries which don't match the desired source.
-            if (strWantFile != strFile)
-                continue;
----------------
ki.stfu wrote:
> Is strWantFile needed? Seems it's an auxiliary variable.
It's no longer needed with the new code, because you'll never get a file that isn't what was asked for.


Repository:
  rL LLVM

http://reviews.llvm.org/D15593