[Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

[Jim Ingham via lldb-commits]

> On Dec 11, 2015, at 2:01 PM, Todd Fiala via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> 
> 
> On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner <zturner at google.com <mailto:zturner at google.com>> wrote:
> On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits <lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>> wrote:
> Hey Eugene and Greg,
> 
> I thought we were doing spaces before the open parens in places like this:
> 
> -    BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine (NULL,
> ...
> +    BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine(nullptr,
> 
> (see the removal of the space after BreakpointResolverFileLine from the clang-tidy settings I presume).
> 
> Did I misunderstand that?
> 
> This was officially removed from the coding standard some months ago,
> 
> Okay.  Are we 100% in sync with LLVM coding standard guidelines?  If so I can just look there to see what we're supposed to be doing.

No, the differences between the lldb and llvm coding standards are documented in:

http://lldb.llvm.org/lldb-coding-conventions.html

Jim

>  
> but not everyone has adopted this unfortunately.  See r228860.  It pains me to no end that we differ from LLVM, because it leads to exactly these type of problems where people aren't sure what the exact set of rules are.
> 
> 
> 
> -- 
> -Todd
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151211/599fcc9c/attachment.html>