[Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

[Todd Fiala via lldb-commits]

On Fri, Dec 11, 2015 at 2:10 PM, Todd Fiala <todd.fiala at gmail.com> wrote:

>
>
> On Fri, Dec 11, 2015 at 2:04 PM, Zachary Turner <zturner at google.com>
> wrote:
>
>> No, sadly.  We still have 4 space indentation, allman style braces, 120
>> line character limit, return-type-on-separate-line, and a few other
>> differences <http://lldb.llvm.org/lldb-coding-conventions.html>.  I've
>> tried on a couple of occasions to remove some of these differences and move
>> closer to LLDB's style, but it has never gone over well.  I plan to keep
>> trying until I'm dead
>>
>
> Eek, hopefully we can solve that before then!
>
>
>> or working on something else,
>>
>
> I vote for us fixing it rather than that :-)
>
>
>> so if there's anything you can do to help, it would be great :)
>>
>
> Okay.  I thought I heard rumor we were adopting LLVM coding style.
>

Er, rather that we already did.


> I'll find out what our position is on this.  I just thought the LLVM
> standard did include the spaces, but only because of the prolific use of it
> I saw over here.
>
> I'll do some digging here.
>
>
>>
>> On Fri, Dec 11, 2015 at 2:01 PM Todd Fiala <todd.fiala at gmail.com> wrote:
>>
>>> On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner <zturner at google.com>
>>> wrote:
>>>
>>>> On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits <
>>>> lldb-commits at lists.llvm.org> wrote:
>>>>
>>>>> Hey Eugene and Greg,
>>>>>
>>>>> I thought we were doing spaces before the open parens in places like
>>>>> this:
>>>>>
>>>>> -    BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine
>>>>> (NULL,
>>>>> ...
>>>>> +    BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine(
>>>>> nullptr,
>>>>>
>>>>> (see the removal of the space after BreakpointResolverFileLine from
>>>>> the clang-tidy settings I presume).
>>>>>
>>>>> Did I misunderstand that?
>>>>>
>>>>
>>>> This was officially removed from the coding standard some months ago,
>>>>
>>>
>>> Okay.  Are we 100% in sync with LLVM coding standard guidelines?  If so
>>> I can just look there to see what we're supposed to be doing.
>>>
>>>
>>>> but not everyone has adopted this unfortunately.  See r228860.  It
>>>> pains me to no end that we differ from LLVM, because it leads to exactly
>>>> these type of problems where people aren't sure what the exact set of rules
>>>> are.
>>>>
>>>
>>>
>>>
>>> --
>>> -Todd
>>>
>>
>
>
> --
> -Todd
>



-- 
-Todd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151211/7a48831a/attachment.html>