[Lldb-commits] [lldb] r255237 - Differential Revision: http://reviews.llvm.org/D15333

[Aidan Dodds via lldb-commits]

Hi Tamas,

Your right, sorry about that, I will be sure to add a commit message in 
the future.

Thanks,
Aidan

On 10/12/2015 11:10, Tamas Berghammer wrote:
> Hi Aidan,
>
> Next time please add a commit message describing the change itself 
> (next to the review link). In general I think copying the review title 
> and the summary into the commit message is a good baseline. It will 
> help us understand your change when somebody looking at git logs as we 
> don't have to open an external link also.
>
> Thanks,
> Tamas
>
> On Thu, Dec 10, 2015 at 10:14 AM Aidan Dodds via lldb-commits 
> <lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>> wrote:
>
>     Author: aidandodds
>     Date: Thu Dec 10 04:11:49 2015
>     New Revision: 255237
>
>     URL: http://llvm.org/viewvc/llvm-project?rev=255237&view=rev
>     Log:
>     Differential Revision: http://reviews.llvm.org/D15333
>
>     Modified:
>         lldb/trunk/source/Core/DataExtractor.cpp
>
>     Modified: lldb/trunk/source/Core/DataExtractor.cpp
>     URL:
>     http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/DataExtractor.cpp?rev=255237&r1=255236&r2=255237&view=diff
>     ==============================================================================
>     --- lldb/trunk/source/Core/DataExtractor.cpp (original)
>     +++ lldb/trunk/source/Core/DataExtractor.cpp Thu Dec 10 04:11:49 2015
>     @@ -14,6 +14,7 @@
>      #include <limits>
>      #include <sstream>
>      #include <string>
>     +#include <math.h>
>
>      #include "clang/AST/ASTContext.h"
>
>     @@ -1405,24 +1406,21 @@ DumpAPInt (Stream *s, const DataExtracto
>          return offset;
>      }
>
>     -static float half2float (uint16_t half)
>     +static float
>     +half2float (uint16_t half)
>      {
>     -#ifdef _MSC_VER
>     -    llvm_unreachable("half2float not implemented for MSVC");
>     -#else
>     -    union{ float       f; uint32_t    u;}u;
>     +    union { float f; uint32_t u; } u;
>          int32_t v = (int16_t) half;
>     -
>     -    if( 0 == (v & 0x7c00))
>     +
>     +    if (0 == (v & 0x7c00))
>          {
>              u.u = v & 0x80007FFFU;
>              return u.f * ldexpf(1, 125);
>          }
>     -
>     +
>          v <<= 13;
>          u.u = v | 0x70000000U;
>          return u.f * ldexpf(1, -112);
>     -#endif
>      }
>
>      lldb::offset_t
>
>
>     _______________________________________________
>     lldb-commits mailing list
>     lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151210/a6272b59/attachment.html>