<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Tamas,<br>
<br>
Your right, sorry about that, I will be sure to add a commit message
in the future.<br>
<br>
Thanks,<br>
Aidan<br>
<br>
<div class="moz-cite-prefix">On 10/12/2015 11:10, Tamas Berghammer
wrote:<br>
</div>
<blockquote
cite="mid:CAG4H=EKpQ8_DP+ynao6+pmVQ03vfCxAuyK_sBUBOZQvyyGBXDw@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Aidan,
<div><br>
</div>
<div>Next time please add a commit message describing the change
itself (next to the review link). In general I think copying
the review title and the summary into the commit message is a
good baseline. It will help us understand your change when
somebody looking at git logs as we don't have to open an
external link also.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Tamas</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Dec 10, 2015 at 10:14 AM Aidan Dodds via
lldb-commits <<a moz-do-not-send="true"
href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
aidandodds<br>
Date: Thu Dec 10 04:11:49 2015<br>
New Revision: 255237<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=255237&view=rev"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=255237&view=rev</a><br>
Log:<br>
Differential Revision: <a moz-do-not-send="true"
href="http://reviews.llvm.org/D15333" rel="noreferrer"
target="_blank">http://reviews.llvm.org/D15333</a><br>
<br>
Modified:<br>
lldb/trunk/source/Core/DataExtractor.cpp<br>
<br>
Modified: lldb/trunk/source/Core/DataExtractor.cpp<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/DataExtractor.cpp?rev=255237&r1=255236&r2=255237&view=diff"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/DataExtractor.cpp?rev=255237&r1=255236&r2=255237&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/source/Core/DataExtractor.cpp (original)<br>
+++ lldb/trunk/source/Core/DataExtractor.cpp Thu Dec 10
04:11:49 2015<br>
@@ -14,6 +14,7 @@<br>
#include <limits><br>
#include <sstream><br>
#include <string><br>
+#include <math.h><br>
<br>
#include "clang/AST/ASTContext.h"<br>
<br>
@@ -1405,24 +1406,21 @@ DumpAPInt (Stream *s, const
DataExtracto<br>
return offset;<br>
}<br>
<br>
-static float half2float (uint16_t half)<br>
+static float<br>
+half2float (uint16_t half)<br>
{<br>
-#ifdef _MSC_VER<br>
- llvm_unreachable("half2float not implemented for MSVC");<br>
-#else<br>
- union{ float f; uint32_t u;}u;<br>
+ union { float f; uint32_t u; } u;<br>
int32_t v = (int16_t) half;<br>
-<br>
- if( 0 == (v & 0x7c00))<br>
+<br>
+ if (0 == (v & 0x7c00))<br>
{<br>
u.u = v & 0x80007FFFU;<br>
return u.f * ldexpf(1, 125);<br>
}<br>
-<br>
+<br>
v <<= 13;<br>
u.u = v | 0x70000000U;<br>
return u.f * ldexpf(1, -112);<br>
-#endif<br>
}<br>
<br>
lldb::offset_t<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits"
rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>