[Lldb-commits] [PATCH] D14083: Fix race condition in process resume
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Mon Oct 26 10:21:46 PDT 2015
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1074-1079
@@ -1073,2 +1073,8 @@
+ if (! broadcast_sent)
+ BroadcastEvent(eBroadcastBitRunPacketSent, NULL);
+ broadcast_sent = true;
m_private_is_running.SetValue (true, eBroadcastAlways);
> Do we want this to happen even if we fail to send the packet? Should this code be in the else clause above?
It was always sent before this change, so I'd probably keep it that way. If the sending fails, we'll have to tear down the whole process anyway.
More information about the lldb-commits