[Lldb-commits] [PATCH] D14083: Fix race condition in process resume
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Mon Oct 26 10:13:34 PDT 2015
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as we always want to send the broadcast even if the continue packet fails to send.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1074-1079
@@ -1073,2 +1073,8 @@
+ if (! broadcast_sent)
+ BroadcastEvent(eBroadcastBitRunPacketSent, NULL);
+ broadcast_sent = true;
m_private_is_running.SetValue (true, eBroadcastAlways);
Do we want this to happen even if we fail to send the packet? Should this code be in the else clause above?
More information about the lldb-commits