[Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

Eugene Leviant via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 16 10:33:29 PDT 2015


evgeny777 added inline comments.

================
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:835
@@ +834,3 @@
+
+    if (!MI_add_summary(miCategory, "char", MI_char_summary_provider,
+                        lldb::eTypeOptionHideValue | lldb::eTypeOptionSkipPointers))
----------------
granata.enrico wrote:
> Should you also cover "signed char" and "unsigned char" here?
Hmm. I thought that if regex is false, exact match will be done, won't it? If yes than simple char type should be signed, right?


http://reviews.llvm.org/D13799





More information about the lldb-commits mailing list