[Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

Enrico Granata via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 16 10:28:26 PDT 2015

granata.enrico added inline comments.

Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:37
@@ +36,3 @@
+        return false;
+    stream.Printf("%d %s", (int)value.GetValueAsSigned(), value.GetValue());
+    return true;
I would definitely not stop the revision for this but I wonder if it would make sense to try and discover whether "char" is signed or unsigned from the type itself?

Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:835
@@ +834,3 @@
+    if (!MI_add_summary(miCategory, "char", MI_char_summary_provider,
+                        lldb::eTypeOptionHideValue | lldb::eTypeOptionSkipPointers))
Should you also cover "signed char" and "unsigned char" here?


More information about the lldb-commits mailing list