[Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

Kamil Rytarowski via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 1 16:09:20 PDT 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 01.10.2015 23:20, Joerg Sonnenberger via lldb-commits wrote:
> On Thu, Oct 01, 2015 at 10:41:46AM +0000, Pavel Labath via
> lldb-commits wrote:
>> This platform code looks like it was copy-pasted from
>> PlatformFreeBSD. Do you anticipate making significant changes
>> here?
>> 
>> If not, it might be a good idea to share this code with FreeBSD
>> in some way (in fact there is a comment here to make this share
>> code with PlatformPOSIX). @emaste, what do you think about this?
> 
> I was talking about this with Ed and some of the other FreeBSD
> folks when I started my own efforts on LLDB for NetBSD. I think the
> best approach is to start with the patch as is and slowly
> refactoring from that.

I'm for it. Having in sources real-world reference will ease the
refactoring either way.

> IMO it is better here to have a basic working state first.

I've passed my current limits of the size of locally maintainable patch.

For the reference, I have more code locally still in progress of
active research (once I got to ~10k lines of git diff of the support
patch...).

Please help me to make the NetBSD support dept partially canceled.

> The other point we agreed on is that the FreeBSD code and the Linux
> code can often be more shared to, so there is a lot of room for
> improvements in any direction.

Yes, true. Integrating NetBSD will clearly help to spot these points.

> I'd prefer to avoid the classic "the enemy of good" situations
> here.
> 

Yes, please! Better incomplete support in the source trees then once
almost complete but rotting in a local patch...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWDb0eAAoJEEuzCOmwLnZs4YAP/1x9RW31pG6H6v9a9Z4GBEgG
FZy+EM5TMWp1LFBlqyxZuboLAp00E+KMHr9oM78zbrQbhng3Lf0K62nZBJKD3Zx7
Az56XBPreqdwUxMJsydD7tKXhDKldCm+1XR/8RE1xaPoG1l6qn0v6pQZek96P1RB
UJ9XCHB+w33IskbfkjK2zoIyA/KFOL4pGxHVtwdINxbeVMo8e7az2PVHspEd5IQe
vBDDlUNZU6x2xGlf9B09taUW+RcpRMrH/8OUagmqBei+v68hDaaL40GoCfMaOl1m
qV+6j0SbP4UEt9VN8gTgWkR1s4jb6PlX0eG5ktGr6cEQA3vO8kh4YmKQOJo6tF3w
y43DnQgwJBXRnNVQ60xWH+XNyBBtV6dl67DBWx1aFOORo9bseXW+KrGpjoLagQru
ZIKgIC1bt2R9wn+8vmYtp2cWac2YZHJZiT6jwWmLm796+Kb8tibnceHacPeoYFSx
LJy608GFTdUh/Zqje2J5SgL23w/Iti2ZZ6cUd1T/XpMnN8uzIH0EFXz80HVuEwvw
314PbVSYUKoOpQBLqigvOGk2SMTQm3gC5MUIX9JZBaDw2xTOyx/p9jxi2dtxPX73
Sr9WC9xKYpftDjff94MEqXqd1aSst4i5h0dCY9RcY+qFiSTYcq8jymfpTcrF44fx
UA+78iMc8QP+UOrx+hur
=Eogw
-----END PGP SIGNATURE-----


More information about the lldb-commits mailing list