[Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

Joerg Sonnenberger via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 1 14:20:09 PDT 2015


On Thu, Oct 01, 2015 at 10:41:46AM +0000, Pavel Labath via lldb-commits wrote:
> This platform code looks like it was copy-pasted from PlatformFreeBSD.
> Do you anticipate making significant changes here?
> 
> If not, it might be a good idea to share this code with FreeBSD in some
> way (in fact there is a comment here to make this share code with
> PlatformPOSIX). @emaste, what do you think about this?

I was talking about this with Ed and some of the other FreeBSD folks
when I started my own efforts on LLDB for NetBSD. I think the best
approach is to start with the patch as is and slowly refactoring from
that. IMO it is better here to have a basic working state first.

The other point we agreed on is that the FreeBSD code and the Linux code
can often be more shared to, so there is a lot of room for improvements
in any direction. I'd prefer to avoid the classic "the enemy of good"
situations here.

Joerg


More information about the lldb-commits mailing list