[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

[Todd Fiala via lldb-commits]

tfiala added inline comments.

================
Comment at: test/test_runner/test/process_control_tests.py:63
@@ +62,3 @@
+    def _suppress_soft_terminate(cls, command):
+        if platform.system() == 'nt':
+            # Add whatever is needed to the command line to
----------------
zturner wrote:
> Change `nt` to `Windows` (unless you're removing this logic as discussed earlier)
Ah okay.  I was copying the "nt" from somewhere else in the source code.  We might want to grep for that if it is wholesale wrong.  I assumed that was leftover from transition over to the NT codebase in W2k time period.

================
Comment at: test/test_runner/test/process_control_tests.py:80
@@ +79,3 @@
+        # Base command.
+        command = (["python", "inferior.py"])
+
----------------
zturner wrote:
> Change `"python"` to `sys.executable`
Okay.  Better.


http://reviews.llvm.org/D13124