[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

[Zachary Turner via lldb-commits]

Random thought: If you want to generate a core dump, we already have LLDB
attached to the process, so you have an SBProcess.  Couldn't you use
Process.Halt, then call whatever method is necessary to have the debugger
create a core, then Process.Kill?

On Mon, Sep 28, 2015 at 1:03 PM Zachary Turner <zturner at google.com> wrote:

> zturner added a comment.
>
> A few more comments
>
>
> ================
> Comment at: test/test_runner/test/process_control_tests.py:63
> @@ +62,3 @@
> +    def _suppress_soft_terminate(cls, command):
> +        if platform.system() == 'nt':
> +            # Add whatever is needed to the command line to
> ----------------
> Change `nt` to `Windows` (unless you're removing this logic as discussed
> earlier)
>
> ================
> Comment at: test/test_runner/test/process_control_tests.py:80
> @@ +79,3 @@
> +        # Base command.
> +        command = (["python", "inferior.py"])
> +
> ----------------
> Change `"python"` to `sys.executable`
>
>
> http://reviews.llvm.org/D13124
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150928/7212792a/attachment.html>