[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 24 10:37:28 PDT 2015


tfiala added a comment.



> Which reminds me of another thing: Since you're working heavily on the tet

>  suite, one thing I've always wanted is what I just mentioned: Something

>  like an lldbxplat module which is essentially a helper module that exposes

>  a single interface for doing things that differ depending on the platform.

>  This would essentially let us remove almost every single occurrence of `if

>  sys.name.startswith('win32')` from the entire test suite, which would

>  really help maintainability.


That's a good idea.  I'm (somewhat slowly) attempting to work in some clean up each time I touch it.  I'll hit that at some point.  I'll start winding down on changes to the test infrastructure soon-ish.  If I don't hit that by the time I stop heavy changes, definitely feel free to jump on it!


http://reviews.llvm.org/D13124





More information about the lldb-commits mailing list