[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 24 10:23:58 PDT 2015

I'm ok with leaving some straggling processes on Windows for now, because
it's obviously better than what we have currently, which is nothing.  I can
implement some sort of helper module at some point that exposes a new
createProcess function that supports this for Windows and Unix with a
single interface once it becomes a problem.

Which reminds me of another thing: Since you're working heavily on the tet
suite, one thing I've always wanted is what I just mentioned: Something
like an lldbxplat module which is essentially a helper module that exposes
a single interface for doing things that differ depending on the platform.
This would essentially let us remove almost every single occurrence of `if
sys.name.startswith('win32')` from the entire test suite, which would
really help maintainability.

It's something I'll get to myself one day if nobody else beats me, but
since you're making a lot of great improvements to the test suite recently,
figured I'd throw it out there.

On Thu, Sep 24, 2015 at 8:54 AM Todd Fiala <todd.fiala at gmail.com> wrote:

> tfiala added a comment.
> > Thanks for working on this once again :)
> Sure thing!
> http://reviews.llvm.org/D13124
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150924/f5b17b38/attachment.html>

More information about the lldb-commits mailing list