[Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

[Enrico Granata via lldb-commits]

> On Sep 23, 2015, at 12:42 PM, Dawn Perchik via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> dawn added a subscriber: dawn.
> dawn raised a concern with this commit.
> dawn added a comment.
> 
> Hi Enrico,
> 
> This commit has caused catasrophic test failures on OSX.  The failure count went
> up by 512.
> 
> lldb is built with cmake/ninja, and tests are run in the test dir as follows:
> 
>  cd ~/llvm
>  mkdir -p build_ninja && cd build_ninja
>  cmake -G Ninja .. "-DLLVM_TARGETS_TO_BUILD=ARM;X86;AArch64" -DCMAKE_CXX_FLAGS="-std=c++11 -stdlib=libc++" -DCMAKE_BUILD_TYPE=Release
>  security unlock-keychain -p <psw>  /Users/testuser/Library/Keychains/login.keychain
>  ninja
>  cd ../tools/lldb/test
>  ./dotest.py --output-on-success -v
> 
> Can you have a look please?
> 
> Thanks in advance,
> -Dawn
> 
> 
> Users:
>  dawn (Auditor)
> 
> http://reviews.llvm.org/rL248338
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Dawn,
I can certainly take a look at this, but I don’t anticipate finding much

We have been running in this mode (with run meaning —shell-expand-args) for months now internally, with no catastrophic test failures
Also, there is a test case that specifically validates launching via argdumper

Are you able to manually launch *any* inferior with an lldb built this way? Is argdumper being built as part of your builds?

Thanks,
- Enrico
📩 egranata@.com ☎️ 27683

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150923/4e472f95/attachment.html>