<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 23, 2015, at 12:42 PM, Dawn Perchik via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">dawn added a subscriber: dawn.<br class="">dawn raised a concern with this commit.<br class="">dawn added a comment.<br class=""><br class="">Hi Enrico,<br class=""><br class="">This commit has caused catasrophic test failures on OSX. The failure count went<br class=""> up by 512.<br class=""><br class="">lldb is built with cmake/ninja, and tests are run in the test dir as follows:<br class=""><br class=""> cd ~/llvm<br class=""> mkdir -p build_ninja && cd build_ninja<br class=""> cmake -G Ninja .. "-DLLVM_TARGETS_TO_BUILD=ARM;X86;AArch64" -DCMAKE_CXX_FLAGS="-std=c++11 -stdlib=libc++" -DCMAKE_BUILD_TYPE=Release<br class=""> security unlock-keychain -p <psw> /Users/testuser/Library/Keychains/login.keychain<br class=""> ninja<br class=""> cd ../tools/lldb/test<br class=""> ./dotest.py --output-on-success -v<br class=""><br class="">Can you have a look please?<br class=""><br class="">Thanks in advance,<br class="">-Dawn<br class=""><br class=""><br class="">Users:<br class=""> dawn (Auditor)<br class=""><br class=""><a href="http://reviews.llvm.org/rL248338" class="">http://reviews.llvm.org/rL248338</a><br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">lldb-commits mailing list<br class="">lldb-commits@lists.llvm.org<br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits<br class=""></div></div></blockquote></div><div class=""><br class=""></div>Dawn,<div class="">I can certainly take a look at this, but I don’t anticipate finding much</div><div class=""><br class=""></div><div class="">We have been running in this mode (with run meaning —shell-expand-args) for months now internally, with no catastrophic test failures</div><div class="">Also, there is a test case that specifically validates launching via argdumper</div><div class=""><br class=""></div><div class="">Are you able to manually launch *any* inferior with an lldb built this way? Is argdumper being built as part of your builds?</div><div class=""><div class="">
<div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="Apple-interchange-newline">Thanks,</div><div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div>
</div>
<br class=""></div></body></html>