[Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.
Siva Chandra via lldb-commits
lldb-commits at lists.llvm.org
Tue Sep 22 14:43:51 PDT 2015
sivachandra added a comment.
I did not touch the base classes part because there is a comment in DWARFASTParserClang::CompleteTypeFromDWARF as:
// We have no choice other than to pretend that the base class
// is complete. If we don't do this, clang will crash when we
// call setBases() inside of "clang_type.SetBaseClassesForClassType()"
// below. Since we provide layout assistance, all ivars in this
// class and other classes will be fine, this is the best we can do
// short of crashing.
I assumed it was being properly handled and did not try an example with it. I did now and LLDB crashes. Do you suggest that I modify to return false if a base class also has incomplete type?
More information about the lldb-commits