[Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

[Greg Clayton via lldb-commits]

clayborg added a comment.

We also need to make sure that if the class is specified anywhere else within the current binary (in another .o file), that we find that class definition and use it in place of the forward declaration. So if you can make another test with the same source file, and another one where std::string _is_ defined, and make sure that the above example succeeds in finding the complete type for std::string elsewhere in the binary that would be great. Same applies to DW_TAG_inheritance tags that point to incomplete types. 1 test for this, and one for when DW_TAG_inheritance points to a forward decl, but we have a full decl elsewhere in another compile unit within the same binary.


http://reviews.llvm.org/D13066