[Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux
Bruce Mitchener via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 16 01:41:32 PDT 2015
brucem added a subscriber: brucem.
Comment at: tools/driver/CMakeLists.txt:13
@@ +12,3 @@
+ add_dependencies(lldb lldb-server)
> We should probably add a dependency on debugserver on darwin for consistency, since some people use cmake to build lldb there also.
Instead of checking `CMAKE_SYSTEM_NAME` in multiple places for deciding whether or not we care about `lldb-server`, could we just set `LLDB_BUILD_LLDB_SERVER` or something once in the `cmake/module/LLDBConfig.cmake` file and then check that here and in `tools/CMakeLists.txt`?
(These have already diverged as you are only doing this for Linux, but `lldb-server` is built on FreeBSD as well.)
More information about the lldb-commits