[Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

Paul Herman via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 14 13:57:46 PDT 2015

paulherman added a comment.

If I move the call to DeclLinkDeclToObject inside any of the GetDeclXXX methods, then there is no way to access the VariableSP needed for the call and it is probably harder to reconstruct the parameters needed for ParseVariableDIE starting from just the DIE itself.

Also, the call is already lazy since ParseVariableDIE is lazy (i.e. whenever the VariableSP is needed, the Decl is needed). I don't think there is any way to separate the call to DeclLinkDeclToObject from ParseVariableDIE, only to make sure that DeclLinkDeclToObject doesn't do any work if it is called with a previously encountered variable.


More information about the lldb-commits mailing list