[Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

[Greg Clayton via lldb-commits]

clayborg added a comment.

In http://reviews.llvm.org/D12658#245547, @paulherman wrote:

> Are you suggesting that the DeclLinkToObject is moved inside the GetDecl call and I only remove that?


Yes, actually you can probably move it into SymbolFileDWARF::GetDeclForUID(). there should be a cache in this function right? If the item isn't in the cache then we cache it and call DeclLinkToObject().

BTW: DeclLinkToObject() might be able to be moved into the base TypeSystem class?

> This is the only place where GetDecl is called, so it would be equivalent from a computational point of view.


Yep, don't care how it happens, I just want it to be lazy and only done if someone asks for it.


http://reviews.llvm.org/D12658