[Lldb-commits] [PATCH] D12750: Link NetBSD with execinfo (CMAKE build)
Bruce Mitchener via lldb-commits
lldb-commits at lists.llvm.org
Thu Sep 10 17:53:54 PDT 2015
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
This revision now requires changes to proceed.
Comment at: cmake/LLDBDependencies.cmake:152
@@ -153,1 +151,3 @@
+# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
+if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
list(APPEND LLDB_SYSTEM_LIBS execinfo)
This should really be replaced with a cmake-style check for where to find backtrace.
cmake 3.0 added a built-in package to handle this, but I think we still support an older cmake:
Since this is how the cmake build finds this, we don't need to worry about having other build systems here and we can do this in the correct way for cmake.
More information about the lldb-commits