[Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

Kamil Rytarowski via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 10 16:49:36 PDT 2015


krytarowski added inline comments.

================
Comment at: source/Host/posix/PipePosix.cpp:39
@@ -38,3 +38,3 @@
 
-// pipe2 is supported by Linux, FreeBSD v10 and higher.
+// pipe2 is supported by Linux, FreeBSD v10 and higher, NetBSD 6.0 and newer
 // TODO: Add more platforms that support pipe2.
----------------
emaste wrote:
> My preference is that we don't repeat the list of platforms in the comments when we have cases like this - perhaps just change to `// pipe2 is supported by a limited set of platforms` or so?
> 
> Presumably you're only interested in recent NetBSD versions while getting support working?
I will rediff the comment.

Yes, I'm just interested with the -current version. I'm working with the NetBSD to add missing bits to extend the system capabilities for larger possibe lldb support.


Repository:
  rL LLVM

http://reviews.llvm.org/D12746





More information about the lldb-commits mailing list