[Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

[Jim Ingham via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

This looks fine to me.  You might want to add LIBLLDB_LOG_BREAKPOINT to your log creation, you can them together, and if I was tracking breakpoints with "log enable lldb breakpoint" I'd expect to see these logs.

You might also consider giving all your kernel breakpoints some convenient name (using Breakpoint::AddName)  That would allow users, e.g. to disable all the breakpoints set on kernels, or add hit counts, etc.  When I get a little spare time I'm going to add the ability to add breakpoint commands to a name, and have it apply to all breakpoints with that name, so that will make this even more useful.  If you do this, just be sure to choose something like RenderScriptKernel or whatever that won't be a commonly chosen name.


Repository:
  rL LLVM

http://reviews.llvm.org/D12728