[Lldb-commits] [PATCH] D12714: Fix log message warning in SBThread.

Bruce Mitchener via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 8 17:02:07 PDT 2015


brucem created this revision.
brucem added reviewers: clayborg, jingham.
brucem added a subscriber: lldb-commits.

The format string was not set up correctly as it was missing the %.
This resulted in a warning (correctly) that the data arguments were
not all used.

http://reviews.llvm.org/D12714

Files:
  source/API/SBThread.cpp

Index: source/API/SBThread.cpp
===================================================================
--- source/API/SBThread.cpp
+++ source/API/SBThread.cpp
@@ -886,7 +886,7 @@
         Thread *thread = exe_ctx.GetThreadPtr();
         if (sb_frame.GetThread().GetThreadID() != thread->GetID())
         {
-            log->Printf("SBThread(%p)::StepOutOfFrame passed a frame from another thread (0x" PRIx64 " vrs. 0x" PRIx64 ", returning.",
+            log->Printf("SBThread(%p)::StepOutOfFrame passed a frame from another thread (0x%" PRIx64 " vrs. 0x%" PRIx64 ", returning.",
                         static_cast<void*>(exe_ctx.GetThreadPtr()),
                         sb_frame.GetThread().GetThreadID(),
                         thread->GetID());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12714.34282.patch
Type: text/x-patch
Size: 751 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150909/fa8f89ff/attachment.bin>


More information about the lldb-commits mailing list