[Lldb-commits] [PATCH] D12699: Change the looping stack detection code

[Jason Molenda via lldb-commits]

jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

I'm fine with this change.  On x86, where the CALL instruction pushes the return address on the stack, you can't have two stack frames with the CFA.  If we have a loop, I don't think it's a big problem if we only break out once it's a 3-stack-frame loop.

I'm not sure it's possible to have an arbitrary number of stack frames with the same CFA - the return addresses have to be saved somewhere.  The register file only gives us so many volatile registers we can use to save multiple stack frame's return addresses before we need to write something to the stack.


http://reviews.llvm.org/D12699