[Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

[Dawn Perchik via lldb-commits]

dawn retitled this revision from "[LLDB-MI] Fix -data-info-line when Windows filenames are used." to "[LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.".
dawn updated the summary for this revision.
dawn updated this revision to Diff 34255.
dawn added a comment.

This changes the code to use regex to handle the parsing.  It is cleaner, more accurate, and faster than the previous code, while not requiring special support to check for Windows paths.

In reworking this patch, I discovered a major bug in -symbol-list-lines where it didn't check the filename so would report lines in header files as belonging to the compilation unit.  That is fixed in this patch and a test added, but to fix -symbol-list-lines for header files requires a rewrite of -symbol-list-lines which I didn't have time for.   I've added a FIXME for now.


Repository:
  rL LLVM

http://reviews.llvm.org/D12115

Files:
  test/tools/lldb-mi/symbol/Makefile
  test/tools/lldb-mi/symbol/TestMiSymbol.py
  test/tools/lldb-mi/symbol/main.cpp
  test/tools/lldb-mi/symbol/x.cpp
  test/tools/lldb-mi/symbol/x.h
  tools/lldb-mi/MICmdCmdData.cpp
  tools/lldb-mi/MICmdCmdSymbol.cpp
  tools/lldb-mi/MIUtilString.cpp
  tools/lldb-mi/MIUtilString.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12115.34255.patch
Type: text/x-patch
Size: 21583 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150908/3ddeb8cb/attachment-0001.bin>