[Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 7 13:51:26 PDT 2015


Looks fine, do you have commit access?  If so feel free to commit
whenever.  Otherwise I can do it for you tomorrow

On Mon, Sep 7, 2015 at 1:15 PM Jeremi Piotrowski <
jeremi.piotrowski at gmail.com> wrote:

> jeremi.piotrowski updated this revision to Diff 34169.
> jeremi.piotrowski added a comment.
>
> - combine nested if conditions with `and` as suggested by zturner
>
>   and remove condtition from `endif` as that seems to be the convention.
>
>
> http://reviews.llvm.org/D12672
>
> Files:
>   cmake/LLDBDependencies.cmake
>
> Index: cmake/LLDBDependencies.cmake
> ===================================================================
> --- cmake/LLDBDependencies.cmake
> +++ cmake/LLDBDependencies.cmake
> @@ -146,6 +146,9 @@
>    endif()
>    if (NOT LLDB_DISABLE_CURSES)
>      list(APPEND LLDB_SYSTEM_LIBS panel ncurses)
> +    if(LLVM_ENABLE_TERMINFO AND HAVE_TERMINFO)
> +      list(APPEND LLDB_SYSTEM_LIBS ${TERMINFO_LIBS})
> +    endif()
>    endif()
>  endif()
>  # On FreeBSD backtrace() is provided by libexecinfo, not libc.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150907/f6c1eaa3/attachment.html>


More information about the lldb-commits mailing list