[Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

[Kamil Rytarowski via lldb-commits]

krytarowski added a comment.

I've inlined replies to your comments.


================
Comment at: include/lldb/Host/HostGetOpt.h:11
@@ -10,3 +10,1 @@
 
-#ifndef _MSC_VER
-
----------------
labath wrote:
> How about just putting here
> ```
> #if !defined(_MSC_VER) && !defined(__NetBSD__)
> ```
I dislike having two headers for the same purpose, can I just obsolete GetOptInc.h and put its content here?

================
Comment at: source/Host/CMakeLists.txt:12
@@ -11,2 +11,3 @@
   common/FileSystem.cpp
+  common/GetOptInc.cpp
   common/Host.cpp
----------------
labath wrote:
> This will compile the file for all targets, which causes errors e.g. on linux. Either make the inclusion of this file conditional in cmake, or put the entire cpp file contents under appropriate ifdefs (windows or netbsd).
I will put the entire file under #ifdefs, I will reuse the defines REPLACE_GETOPT from .h.

For platforms with all needed getopt(3) functions. I will add a dummy local variable, like static int getopt_dummy = 0; This will be needed to feed ld(1) on some toolchains.


Repository:
  rL LLVM

http://reviews.llvm.org/D12582