[Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

[Pavel Labath via lldb-commits]

labath added a comment.

Thanks for merging the two implementations. However, the way you have implemented it enables the getopt replacement for all platforms. We need to have it on only for platforms that don't have a native one.


================
Comment at: include/lldb/Host/HostGetOpt.h:11
@@ -10,3 +10,1 @@
 
-#ifndef _MSC_VER
-
----------------
How about just putting here
```
#if !defined(_MSC_VER) && !defined(__NetBSD__)
```

================
Comment at: source/Host/CMakeLists.txt:12
@@ -11,2 +11,3 @@
   common/FileSystem.cpp
+  common/GetOptInc.cpp
   common/Host.cpp
----------------
This will compile the file for all targets, which causes errors e.g. on linux. Either make the inclusion of this file conditional in cmake, or put the entire cpp file contents under appropriate ifdefs (windows or netbsd).


Repository:
  rL LLVM

http://reviews.llvm.org/D12582