[Lldb-commits] [lldb] r246518 - Attempt at fixing the CMake build

[Pavel Labath via lldb-commits]

Hello,

the cmake fixes seem fine, but something about your changes broke all
libcxx tests, regardless of the build system: osx/xcode: <
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5309>,
linux/cmake: <
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/5758>.
I think the problem is relatively minor, but I lack the knowledge to fix
it, so I have reverted these changes until you can investigate.

pl

On 1 September 2015 at 02:26, Enrico Granata via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

>
> On Aug 31, 2015, at 6:23 PM, Enrico Granata via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>
> Author: enrico
> Date: Mon Aug 31 20:23:02 2015
> New Revision: 246518
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246518&view=rev
> Log:
> Attempt at fixing the CMake build
>
> Modified:
>    lldb/trunk/cmake/LLDBDependencies.cmake
>    lldb/trunk/source/Plugins/Language/CMakeLists.txt
>
> Modified: lldb/trunk/cmake/LLDBDependencies.cmake
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/LLDBDependencies.cmake?rev=246518&r1=246517&r2=246518&view=diff
>
> ==============================================================================
> --- lldb/trunk/cmake/LLDBDependencies.cmake (original)
> +++ lldb/trunk/cmake/LLDBDependencies.cmake Mon Aug 31 20:23:02 2015
> @@ -20,6 +20,10 @@ set( LLDB_USED_LIBS
>   lldbPluginDynamicLoaderPosixDYLD
>   lldbPluginDynamicLoaderHexagonDYLD
>   lldbPluginDynamicLoaderWindowsDYLD
> +
> +  lldbPluginCPlusPlusLanguage
> +  lldbPluginObjCLanguage
> +  lldbPluginObjCPlusPlusLanguage
>
>   lldbPluginObjectFileELF
>   lldbPluginObjectFileJIT
>
> Modified: lldb/trunk/source/Plugins/Language/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Language/CMakeLists.txt?rev=246518&r1=246517&r2=246518&view=diff
>
> ==============================================================================
> --- lldb/trunk/source/Plugins/Language/CMakeLists.txt (original)
> +++ lldb/trunk/source/Plugins/Language/CMakeLists.txt Mon Aug 31 20:23:02
> 2015
> @@ -1,2 +1,3 @@
> add_subdirectory(CPlusPlus)
> add_subdirectory(ObjC)
> +add_subdirectory(ObjCPlusLus)
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
> This commit - and the next - are my best guess at fixing the CMake build
> after my formatter changes in r 246515
> If they were to prove insufficient, I would appreciate somebody with more
> CMake-fu than myself pointing me in the right direction
>
> Thanks,
> *- Enrico*
> 📩 egranata@.com ☎️ 27683
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150901/7318aa0f/attachment.html>