<div dir="ltr">Hello,<div><br></div><div>the cmake fixes seem fine, but something about your changes broke all libcxx tests, regardless of the build system: osx/xcode: <<a href="http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5309">http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5309</a>>, linux/cmake: <<a href="http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/5758">http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/5758</a>>. I think the problem is relatively minor, but I lack the knowledge to fix it, so I have reverted these changes until you can investigate.</div><div><br></div><div>pl</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 1 September 2015 at 02:26, Enrico Granata via lldb-commits <span dir="ltr"><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div class="h5"><br><div><blockquote type="cite"><div>On Aug 31, 2015, at 6:23 PM, Enrico Granata via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:</div><br><div><div>Author: enrico<br>Date: Mon Aug 31 20:23:02 2015<br>New Revision: 246518<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=246518&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=246518&view=rev</a><br>Log:<br>Attempt at fixing the CMake build<br><br>Modified:<br> lldb/trunk/cmake/LLDBDependencies.cmake<br> lldb/trunk/source/Plugins/Language/CMakeLists.txt<br><br>Modified: lldb/trunk/cmake/LLDBDependencies.cmake<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/LLDBDependencies.cmake?rev=246518&r1=246517&r2=246518&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/LLDBDependencies.cmake?rev=246518&r1=246517&r2=246518&view=diff</a><br>==============================================================================<br>--- lldb/trunk/cmake/LLDBDependencies.cmake (original)<br>+++ lldb/trunk/cmake/LLDBDependencies.cmake Mon Aug 31 20:23:02 2015<br>@@ -20,6 +20,10 @@ set( LLDB_USED_LIBS<br> lldbPluginDynamicLoaderPosixDYLD<br> lldbPluginDynamicLoaderHexagonDYLD<br> lldbPluginDynamicLoaderWindowsDYLD<br>+ <br>+ lldbPluginCPlusPlusLanguage<br>+ lldbPluginObjCLanguage<br>+ lldbPluginObjCPlusPlusLanguage<br><br> lldbPluginObjectFileELF<br> lldbPluginObjectFileJIT<br><br>Modified: lldb/trunk/source/Plugins/Language/CMakeLists.txt<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Language/CMakeLists.txt?rev=246518&r1=246517&r2=246518&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Language/CMakeLists.txt?rev=246518&r1=246517&r2=246518&view=diff</a><br>==============================================================================<br>--- lldb/trunk/source/Plugins/Language/CMakeLists.txt (original)<br>+++ lldb/trunk/source/Plugins/Language/CMakeLists.txt Mon Aug 31 20:23:02 2015<br>@@ -1,2 +1,3 @@<br> add_subdirectory(CPlusPlus)<br> add_subdirectory(ObjC)<br>+add_subdirectory(ObjCPlusLus)<br><br><br>_______________________________________________<br>lldb-commits mailing list<br><a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br></div></div></blockquote></div><br></div></div><div>This commit - and the next - are my best guess at fixing the CMake build after my formatter changes in r 246515</div><div>If they were to prove insufficient, I would appreciate somebody with more CMake-fu than myself pointing me in the right direction</div><div>
<div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br>Thanks,</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div>
</div>
<br></div><br>_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><br></div>