[Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

[Jim Ingham via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

So there are two issues I see here.

The first is that you seem to have invented a parallel mechanism to the breakpoint resolver mechanism to handle re-resolving breakpoints on shared library loads.  That seems unfortunate.  You should have been able to add a special RSBreakpointResolver that will get called by the ordinary mechanism for breakpoints on new module load and then just make new "RS Kernel" breakpoints with that resolver.  I would want a good reason why that wasn't possible before I would feel good about adding this side mechanism.

The second issue, which Greg pointed out, is that there's no way for a plugin to specify a new breakpoint resolver kind that it has added to the breakpoint system.  Since that doesn't currently exist, and is a decent bit of work which it isn't fair to gate this patch on, I don't mind for the nonce adding a special command to set them.  But the breakpoint's resolver describes the breakpoints in a resolver agnostic way, so once added there is no need for "list" or "delete" commands.


Repository:
  rL LLVM

http://reviews.llvm.org/D12360