[Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Looks good for now, but we should add a way so that plug-ins can extend the "breakpoint set", "breakpoint delete", and other breakpoint commands so we don't have a bunch of fragmented extra commands.

One idea for a future patch: allow plugins to define static functions callbacks that can add new options to breakpoint commands and have the command routed to the plug-in when these special commands are specified. Lets say you set a renderscript kernel breakpoint by installing a new --renderscript-kernel option:

  (lldb) breakpoint set --renderscript-kernel ...

The arguments would get parsed up and passed to a plug-in static function when the breakpoint gets requested to be made. We might not have a renderscript runtime loaded yet because we haven't detected the renderscript shared library yet, so we would need to hold off on resolving the breakpoint until the RenderScriptRuntime plug-in is loaded, and as soon as it is, the breakpoint could resolve itself.

We have a desire for this with the Objective C runtime to do special breakpoints like:

  (lldb) breakpoint set --objc-class NString


Repository:
  rL LLVM

http://reviews.llvm.org/D12360