[Lldb-commits] [PATCH] D12025: Make LLDB URLs to support hex encoding for special symbols

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 14 02:12:07 PDT 2015

tberghammer added a comment.

The implementation looks good, but I don't like the approach you try to handle the problem.

I think you do far too much work to use UriParser in a case where it isn't necessary and isn't make things easier. I think a better (and definitely simpler) solution would be to change only ConnectionFileDescriptorPosix.cpp to parse the adb addresses with a locally specified regexp or with looking for the last colon in the address and split the address to host and port based on that.


More information about the lldb-commits mailing list