[Lldb-commits] [PATCH] D12025: Make LLDB URLs to support hex encoding for special symbols

[Oleksiy Vyalov via lldb-commits]

ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer, chaoren.
ovyalov added a subscriber: lldb-commits.

UriParser:Parse expects that host name doesn't contain special URL symbols  - ":", ";", "$",...
However, in case of adb protocol (adb://$device_serial_no:$port) it poses a problem -  device serial number may contain a colon ("192.168.0.1:5555").
In order to handle this situation we can pass URL encoded serial number (adb://192.168.100.132%3A5555:5432) and decode URL components within UriParser::Parse.
As an alternative, there is an option to have a adb-specific regexp in UriParser::Parse but I would like to keep UriParser protocol-independent.   

http://reviews.llvm.org/D12025

Files:
  lldb.xcodeproj/project.pbxproj
  source/Host/posix/ConnectionFileDescriptorPosix.cpp
  source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
  source/Utility/CMakeLists.txt
  source/Utility/UriParser.cpp
  source/Utility/UrlEncoder.cpp
  source/Utility/UrlEncoder.h
  unittests/Utility/CMakeLists.txt
  unittests/Utility/UriParserTest.cpp
  unittests/Utility/UrlEncoderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12025.32125.patch
Type: text/x-patch
Size: 13992 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150814/7b0aeb91/attachment-0001.bin>