[Lldb-commits] [PATCH] D12020: Print unexpected successes at the end of dosep.

[Chaoren Lin via lldb-commits]

chaoren added inline comments.

================
Comment at: test/dosep.py:202
@@ -196,1 +201,3 @@
               if status != ePassed]
+    xpasses = [name for name, status, _, _, unexpected_successes in results if unexpected_successes > 0]
+    
----------------
Don't need status here.

Nit: could you please wrap the `if` like the above?
Nit: `xpasses` reads like "expected passes" to me.

================
Comment at: test/dosep.py:266
@@ -259,2 +266,2 @@
     timed_out = sum([result[0] for result in test_results], [])
     passed = sum([result[1] for result in test_results], [])
----------------
There's a line above this:
```
# result = (timed_out, failed, passed, fail_count, pass_count)
```
that needs to be updated.

(could you please include all context in the future? I recommend using [[ https://secure.phabricator.com/book/phabricator/article/arcanist/ | arcanist ]])

================
Comment at: test/dosep.py:500
@@ +499,3 @@
+        for u in unexpected_successes:
+            print "UNEXPECTED SUCCESS: LLDB (suite) :: %s (%s)" % (u, system_info)
+
----------------
I wonder if it'll be worthwhile to include the count (i.e., x  unexpected successes out of y expected failures)


http://reviews.llvm.org/D12020